Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added go replace recommendation to README for local development #226

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Added go replace recommendation to README for local development #226

merged 1 commit into from
Mar 31, 2021

Conversation

nasmithan
Copy link
Contributor

This adds documentation on how to reference local changes while developing against both rosetta-sdk-go and rosetta-cli.

Motivation

https://community.rosetta-api.org/t/how-to-develop-rosetta-cli/335/6

Solution

Added instructions to use go replace

@nasmithan nasmithan requested a review from septerr March 31, 2021 21:20
septerr
septerr approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@septerr septerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nasmithan nasmithan force-pushed the nasmithan/add-go-replace-to-readme branch from e8a0bb0 to 57642a4 Compare March 31, 2021 22:42
@nasmithan nasmithan merged commit e1fc8df into master Mar 31, 2021
@nasmithan nasmithan deleted the nasmithan/add-go-replace-to-readme branch March 31, 2021 22:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7000

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 64 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-3.4%) to 38.786%
Files with Coverage Reduction New Missed Lines %
cmd/check_data.go 5 0%
cmd/check_construction.go 8 0%
cmd/root.go 51 37.91%
Totals Coverage Status
Change from base Build 6985: -3.4%
Covered Lines: 588
Relevant Lines: 1516
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@septerr septerr septerr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nasmithan @coveralls @septerr